Skip to content

[CI/Build] Add terratorch for AMD #29205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2025
Merged

[CI/Build] Add terratorch for AMD #29205

merged 2 commits into from
Nov 22, 2025
+3 −0

Conversation

@rjrock
Copy link
Contributor

@rjrock rjrock commented Nov 21, 2025 •
edited by github-actions bot
Loading

Purpose

This PR adds the terratorch dependency to the ROCm CI such that the 'Plugin Tests (2 GPUs)' test group passes.

Test Plan

See the plugin tests group.

Test Result

Test Command Result
pytest -v -s plugins_tests/test_platform_plugins.py 2 passed, 3 warnings (1.44s)
pytest -v -s plugins_tests/test_io_processor_plugins.py 3 passed, 6 warnings (55.99s)
pytest -v -s plugins_tests/test_stats_logger_plugins.py 4 passed, 3 warnings (10.92s)
pytest -v -s plugins_tests/test_scheduler_plugins.py 1 passed, 3 warnings (8.10s)
pytest -v -s distributed/test_distributed_oot.py 1 passed, 3 warnings (34.44s)
pytest -v -s entrypoints/openai/test_oot_registration.p 1 passed, 3 warnings (22.18s)
pytest -v -s models/test_oot_registration.py 4 passed, 3 warnings (27.75s)
pytest -v -s plugins/lora_resolvers 3 passed, 3 warnings (1.08s)
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@rjrock rjrock requested a review from tjtanaa as a code owner November 21, 2025 21:26
@mergify mergify bot added the ci/build label Nov 21, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the terratorch dependency for ROCm tests. My review suggests aligning the terratorch dependency with the one used for CUDA tests. The CUDA environment uses a specific git commit of terratorch, which likely includes important vLLM-specific fixes. Using the same dependency for ROCm will ensure consistency and prevent potential issues that might arise from using the PyPI version.

@mergify mergify bot added the rocm Related to AMD ROCm label Nov 21, 2025
@rjrock
Copy link
Contributor Author

rjrock commented Nov 21, 2025

Partially addresses issue #28314

@vllm-bot vllm-bot merged commit ed8e684 into vllm-project:main Nov 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@tjtanaa tjtanaa Awaiting requested review from tjtanaa tjtanaa is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/build rocm Related to AMD ROCm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rjrock @DarkLight1337 @vllm-bot